Skip to content

Conversation

@zherczeg
Copy link
Member

#4646 should land first

@zherczeg zherczeg force-pushed the native_module branch 6 times, most recently from 35219a6 to cf5c4c9 Compare April 13, 2021 07:53
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changes.

* @return true value - if the operation was successful
* error - otherwise
*/
jerry_value_t jerry_native_module_set_export (const jerry_value_t native_module_val, /**< a native module object */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type must go into new line.

**Prototype**

```c
jerry_value_t jerry_native_module_create (jerry_native_module_evaluate_callback_t callback,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, new line.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 7b67434 into jerryscript-project:master Apr 13, 2021
@zherczeg zherczeg deleted the native_module branch April 13, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants