Skip to content

Conversation

@polaroi8d
Copy link
Contributor

As the mbed is a cpp project from which several classes were used we need to have .cpp files.

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu

@polaroi8d
Copy link
Contributor Author

There are some problems with the renamed files, because if we rewrite their names, didn't fint specific libaries, like cstddef.

fatal error: cstddef: No such file or directory

@zherczeg
Copy link
Member

Hi please check the CI report:
https://travis-ci.org/Samsung/jerryscript/jobs/118257205

please run make precommit before submitting a patch

@zherczeg
Copy link
Member

And please squash the commits

#include "jerry_extapi.h"
#include "native_stm32f401nucleo.h"


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you frequently use double newlines. Please remove them.

@zherczeg
Copy link
Member

I would like to mention that porting API is in rework now. See:
#964

After that work completes, some update will likely need for this port


#define __UNSED__ __attribute__((unused))

#define DELCARE_HANDLER(NAME) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: DECLARE_HANDLER

@LaszloLango LaszloLango added development Feature implementation jerry-port Related to the port API or the default port implementation labels Mar 31, 2016
function sysloop(ticknow)
{
blink();
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon after } ?

@zherczeg
Copy link
Member

zherczeg commented Apr 1, 2016

LGTM after style fixes. Please squash and rebase the commit.

Fix DECLAR_HANDLER & double newlines.
delete DECLARE_HANDLER(print)
Check the err_obj_p & released.
Fixed the style issues.

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
@polaroi8d
Copy link
Contributor Author

In this and some other PRs what we did, they are way too much clones of each other, so this is the reason why I'm closed this pull request, because we created a new PR ( #1019 ) where merged the mbed releated targets into one soruce.

@polaroi8d polaroi8d closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Feature implementation jerry-port Related to the port API or the default port implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants