-
Notifications
You must be signed in to change notification settings - Fork 686
Added ST32F401 Nucelo to targets folder. #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are some problems with the renamed files, because if we rewrite their names, didn't fint specific libaries, like cstddef.
|
|
Hi please check the CI report: please run make precommit before submitting a patch |
|
And please squash the commits |
| #include "jerry_extapi.h" | ||
| #include "native_stm32f401nucleo.h" | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you frequently use double newlines. Please remove them.
|
I would like to mention that porting API is in rework now. See: After that work completes, some update will likely need for this port |
|
|
||
| #define __UNSED__ __attribute__((unused)) | ||
|
|
||
| #define DELCARE_HANDLER(NAME) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: DECLARE_HANDLER
| function sysloop(ticknow) | ||
| { | ||
| blink(); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semicolon after } ?
|
LGTM after style fixes. Please squash and rebase the commit. |
Fix DECLAR_HANDLER & double newlines. delete DECLARE_HANDLER(print) Check the err_obj_p & released. Fixed the style issues. JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
|
In this and some other PRs what we did, they are way too much clones of each other, so this is the reason why I'm closed this pull request, because we created a new PR ( #1019 ) where merged the mbed releated targets into one soruce. |
As the mbed is a cpp project from which several classes were used we need to have .cpp files.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu