Skip to content

Conversation

@polaroi8d
Copy link
Contributor

As the mbed is a cpp project from which several classes were used we need to have .cpp files.

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu

@polaroi8d
Copy link
Contributor Author

There are some problems with the renamed files, because if we rewrite their names, didn't find specific libaries, like cstddef.

fatal error: cstddef: No such file or directory

@zherczeg
Copy link
Member

LGTM.
Just one more question: I am surprised that c -> cpp conversions do not cause any linking problems. Is it because of the extern C in api headers?

@LaszloLango LaszloLango added bug Undesired behaviour jerry-port Related to the port API or the default port implementation labels Mar 31, 2016
#include <stdlib.h>
#include <stdio.h>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two empty lines help to separate the include types, such as jerry API, system and target headers. Why did you remove them?

@polaroi8d
Copy link
Contributor Author

@zherczeg I guess.

Delete DECLARE_HANDLER(print) & double newlines.
Set some separator to the include types for good differentiation.
Fix the { usage.
Check the err_obj_p & released.

JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
@akosthekiss
Copy link
Member

@polaroi8d I've taken a closer look at the 4 open mbed-related PRs (this one + #981, #986, #989). They are way too much clones of each other. Except for differences in style (whitespace, comments, order of includes), the js and source directories are copy-paste clones of each other (perhaps the only difference between them is the serial port baud rate set in main.cpp). The real differences seem to be "only" in readme, yotta, module, and make files in the target root directory.

I'd propose unifying the mbed-related targets to prevent duplications. I could imagine a structure like

targets/
    mbed/
        js/
        source/
        port/
        board/
            k64f/
            stm32f401nucleo/
            stm32f4/
            stm32f429i/

Since the k64f support is already in the code base, I propose to update this PR to lay the foundations of the new structure as well as update the code to latest jerry (please note that an external port implementation is needed as identified in #1032).

Do have some discussion with @knightburton to make sure that the other PRs are aligned.

@polaroi8d
Copy link
Contributor Author

@akiss77 there is a new PR #1019 where we already done, what you describe.

@akosthekiss
Copy link
Member

@polaroi8d Ahm, working my way up from the bottom of the list, I did not get that far. My bad. However, if these four PRs are superceded by #1019 then could you please close these with an appropriate comment so they don't show up anymore as ones waiting for review?

@polaroi8d
Copy link
Contributor Author

@akiss77 Of course.

@polaroi8d
Copy link
Contributor Author

polaroi8d commented Apr 29, 2016

In this and some other PRs what we did, they are way too much clones of each other, so this is the reason why I'm closed this pull request, because we created a new PR ( #1019 ) where merged the mbed releated targets into one source.

@polaroi8d polaroi8d closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour jerry-port Related to the port API or the default port implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants