fix(rtorrent): fall back to XML-RPC for torrent list fetch#1098
Merged
trim21 merged 3 commits intojesec:masterfrom Apr 18, 2026
Merged
fix(rtorrent): fall back to XML-RPC for torrent list fetch#1098trim21 merged 3 commits intojesec:masterfrom
trim21 merged 3 commits intojesec:masterfrom
Conversation
Some rTorrent instances return JSON-RPC parse errors (-32700) for the d.multicall2 torrent list request, even though other RPC calls still succeed. This caused Flood to silently fall back to an empty torrent list while transfer stats and add-torrent operations kept working. Retry the torrent list fetch over XML-RPC when that specific JSON-RPC failure occurs, keeping the existing behavior for all other calls.
Collaborator
|
I don't quiet understand, you are linking this PR in #631, are we talking about Deluge or rtorrent? |
Collaborator
|
OK, I know. I need you to add this pr description as comment to the code so we don't need to use |
Contributor
Author
Done, I've also referenced the rTorrent issue #. |
trim21
pushed a commit
to trim21/flood
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some rTorrent instances return JSON-RPC parse errors (-32700) for the d.multicall2 torrent list request, even though other RPC calls still succeed. This caused Flood to silently fall back to an empty torrent list while transfer stats and add-torrent operations kept working.
Retry the torrent list fetch over XML-RPC when that specific JSON-RPC failure occurs, keeping the existing behavior for all other calls.
Types of changes