Coloured file icons?

[jesseduffield]

Topic
This neovim file explorer has coloured icons:

Your thoughts
I think it looks pretty good. What do we think about colouring file icons in lazygit?

[harshsingh32]

coloured icons looks good.

[jesseduffield]

I'm chucking a good-first-issue label on this because it should be straightforward. The only hard part is working out what all the colours should be! But I'm sure that's easy to find online somewhere (just don't use the source code of a repo that's not compatible with our MIT license).

The icons code lives in pkg/gui/presentation/icons/file_icons.go. You'll want to update the mapping from filename extensions to icons to now have both icons and colours as values (you can make a new struct for this).

Next up you can make IconForFile (in the same file) return the colour with the correct string. Then wherever you call IconForFile (e.g. pkg/gui/presentation/files.go) you'll want to allow it to use the colour returned by the function rather than overriding it.

If anybody is up to tackle this, let me know!

[aashish2057]

I can tackle this

[jesseduffield]

Go ahead @aashish2057 :)

[aashish2057]

#3050 In here I show the screenshots of what a icon would look like when setting the fg or bg colors is there a better way to make it look better? If not I think setting just fg color is the better of the two. @jesseduffield

[parga]

@jesseduffield this should be closed right ? there is a PR merged already with this feature #3080

[stefanhaller]

Yes, looks like it. Closing as fixed by #3080.