Continuations of Gh integration

[Yuuki77]

I took over #1406 (comment)
I could not update the original pr.
If there is a way, please let me know!

since It confliced a lot for now, it only shows the pr number associated with branch.

[Yuuki77]

hmm integration tests on ubuntu failed.
I have been investigating.
@jesseduffield do you have any idea? 🙏

[jesseduffield]

@Yuuki77 those failing integration tests relate to pushing/pulling from an origin. I would do some pushing/pulling locally and see if anything weird happens. You can also run an integration test locally with go run test/lazyintegration/main.go (it opens a little gui for selecting the test. If you press enter you'll see it run)

[Yuuki77]

thanks! I will test it as well!
let me try if I can fix it

[jesseduffield]

I know this is a WIP but I left a bit of feedback :)

[Yuuki77]

@jesseduffield Thank you for the quick reviews!
I have updated the pr!
Could you take a look when you have time!

[jesseduffield]

few more things :)

[Yuuki77]

@jesseduffield
It has been some time since my last revision, but I was able to find the time.
I fixed the conflicts, can you review it when you have time? 😄

[Yuuki77]

@jesseduffield I fixed the conflict! I want to get this pr merged.
Let me know if you have any comments!

[jesseduffield]

@Yuuki77 testing this on lazygit it's not quite formatting properly:

[Yuuki77]

@jesseduffield Thank you for the quick reviews!
I updated it and could you try it again?

[jesseduffield]

I've tested again. If I switch repos from A to B, I don't see B's pull request numbers

[Yuuki77]

@jesseduffield that issue should be fixed.

[jesseduffield]

Sorry @Yuuki77 ! I never found the time to properly review this, my bad. I've got some changes locally that I can push:

• more specific error message when gh version command fails (likewise with the git version command)
• moved code from helpers.host_helper to git_commands.hosting_service
• using struct for PR key
• moving PR refresh code into refresh.go, changing logic to work more like reflog commits
• some copy updates

Something we'll want to do before merging this PR is moving the logic from GetRepoInfoFromURL into pkg/commands/hosting_service/hosting_service.go so that we're containing all of our hosting service specific code in the one place (and it will make it easier to support PR numbers for other hosting services down the line).

There's a couple more things that would be good (not necessary for merging the PR):

• support for branches whose UpstreamRemote is of the form 'git@.../lazygit.go'. These don't actually have a remote to match on locally, but they do contain the owner name in the URL
• structuring the code to support other PR structures e.g. not every hosting service has an owner/branch structure: azure has org/project/branch.

@Yuuki77 if you want to step away from this feature that's understandable, I'm happy to pick it up. Thanks for taking the time to work on the feature at any rate :)

[Yuuki77]

@jesseduffield no worries 😄
This is a bigger change than I originally thought, and it would be better to have this feature taken over by someone.
This feature is very useful and I hope it will be merged into master soon!
I really like lazygit, so I will continue to implement other features when I have time. 👍

[jesseduffield]

Good to hear @Yuuki77