Add sign-off feature to git commit#1579
Merged
jesseduffield merged 2 commits intojesseduffield:masterfrom Dec 25, 2021
sagikazarmark:commit-signoff
Merged
Add sign-off feature to git commit#1579jesseduffield merged 2 commits intojesseduffield:masterfrom sagikazarmark:commit-signoff
jesseduffield merged 2 commits intojesseduffield:masterfrom
sagikazarmark:commit-signoff
Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
|
How about adding parameters to the config for the 'git commit' command, like that |
Owner
|
Nice work @sagikazarmark! @Mephistophiles I think such a change could be orthogonal to this one i.e. if the user has set some boolean flags, we'll add those, but we could also allow passing a string. I prefer the boolean approach for now if only because it makes it easier down the line if we want to start using something like go-git under the hood to run the git commands. But if an issue doesn't already exist for such a feature, feel free to create one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable via configuration:
Resubmission of #1031
Fixes #505
To answer the question that came up previously: no, signing-off does not require password entry.
The implementation in this PR is similar to #1031, but I wonder if it would be better to move the signoff flag directly to
GitCommand.CommitCmdStr: it has access to the configuration and the signoff flag should probably always be passed to the git commit command. Let me know what you think and I rework the PR if necessary.