Skip to content

Fix CI erroneously marking failed tests as successful#3221

Merged
jesseduffield merged 1 commit intomasterfrom
test-ci-failure
Jan 16, 2024
Merged

Fix CI erroneously marking failed tests as successful#3221
jesseduffield merged 1 commit intomasterfrom
test-ci-failure

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jan 15, 2024

CI is erroneously saying that our integration tests are passing.

As @stefanhaller says in a comment:

It broke with this commit: aaecd6c. Since that change, the run_integration_tests.sh script will exit with the exit status of the the last mv command, not the test run. Should be pretty easy to fix.

Thanks to Stefan for fixing this

(The reason I'm saying this all here in the PR description is that PR descriptions now get included in merge commits)

@codacy-production
Copy link

codacy-production bot commented Jan 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -2.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (53acbc8) 46026 37884 82.31%
Head commit (cf59b40) 46026 (+0) 37891 (+7) 82.33% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3221) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@stefanhaller
Copy link
Collaborator

@jesseduffield It broke with this commit: aaecd6c. Since that change, the run_integration_tests.sh script will exit with the exit status of the the last mv command, not the test run. Should be pretty easy to fix.

@stefanhaller
Copy link
Collaborator

I pushed a commit to fix the script.

@jesseduffield jesseduffield added the maintenance For refactorings, CI changes, tests, version bumping, etc label Jan 16, 2024
@jesseduffield jesseduffield changed the title break test to see if CI is still broken Fix CI erroneously marking failed tests as successful Jan 16, 2024
@jesseduffield jesseduffield merged commit 8062f96 into master Jan 16, 2024
@jesseduffield jesseduffield deleted the test-ci-failure branch January 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants