Fixed translations for zh_TW#3393
Fixed translations for zh_TW#3393stefanhaller merged 2 commits intojesseduffield:masterfrom olivertzeng:master
Conversation
|
i really dont know how to do git rebase i really cant find a good tutorial for using git rebase interactive mode properly3 |
stefanhaller
left a comment
stefanhaller
left a comment
There was a problem hiding this comment.
i really dont know how to do git rebase
It looks like you figured that out, your commits are sitting on master correctly now. (I had to rebase again though, because another PR was merged meanwhile.)
I didn't merge this yet because there are formatting issues. I could have fixed most of them for you, but I wasn't sure whether the ones in traditionalChineseIntroPopupMessage were intentional, see below.
In the future, please don't make PRs from your master branch; create a feature branch for it instead, this makes it easier for us to push changes to it. Thanks.
pkg/i18n/traditional_chinese.go
Outdated
| 感謝你使用 lazygit，你真的很厲害。有三件事要與你分享： | ||
| 感謝使用 lazygit！這裡有一些資源可供參考： | ||
|
|
||
| 1) 如果你想了解 lazygit 的功能，請看這個影片： | ||
| https://youtu.be/CPLdltN7wgE | ||
| 1) 📺lazygit 教學📺： | ||
| https://youtu.be/CPLdltN7wgE | ||
|
|
||
| 2) 請務必閱讀最新的發布說明： | ||
| https://github.com/jesseduffield/lazygit/releases | ||
| 2) 📣釋出說明📣： | ||
| https://github.com/jesseduffield/lazygit/releases | ||
|
|
||
| 3) 如果你正在使用 git，那麼就是一個程式設計師！在你的幫助下， | ||
| 我們可以使 lazygit 變得更好，請考慮成為貢獻者並一起同樂： | ||
| https://github.com/jesseduffield/lazygit | ||
| 你也可以贊助我，並告訴我有什麼要改進的，點擊右下方的捐贈按鈕即可。 | ||
| 就算是只在版本庫中點個星星分享愛也很棒！ | ||
| 3) 💖如果你想要貢獻一份心力你可以💖： | ||
| 改進 lazygit 原始碼：https://github.com/jesseduffield/lazygit | ||
| 按右下角的捐款斗內我們 | ||
| 或單存添加 lazygit 到你的 star 清單內以增加曝光度都能大力的幫助我們！ |
There was a problem hiding this comment.
The indentation of this message has changed, is there a reason for it? I suppose you have some auto-formatter that did this automatically. I see that the indentation of the glossary above has also changed.
There was a problem hiding this comment.
No I don't. I thought that the indentation isn't necessary. Should I change it back
There was a problem hiding this comment.
Yes, I think it would be good to format it in the same way as the english one, unless there are some language rules in Chinese that speak against it.
There was a problem hiding this comment.
Well, not really, the commit history is still a mess containing merge commits that are impossible to understand, and the file was not auto-formatted correctly. I fixed all this in #3394 as a draft PR, and added a commit to change the indentation back to how it was before; you could now either git reset --hard onto that one and force-push, or we just merge mine. I don't care very much either way.
I do have to say that I found this experience a bit painful, and I don't really like spending time on things like this. On the other hand, I value your contribution and I didn't want your work to be lost, so thanks for your work.
|
I’ll `git reset —hard` on my machine and try not to be an idiot.(I’m a be”git”nner although I use Arch BTW but I don’t know much about git. I’ll go rtfm about how git works) BTW it is my pleasure to contribute to your project! Thanks for being so kind! Your kindness shows why people like me would like to take part in this project!
Sent from Proton Mail for iOS
|
Authored-by: Oliver Tzeng <olivertzeng@proton.me>
|
I went ahead and did the git reset for you, and force-pushed, so that we can close this. |
yay thanks |
2 participants
Improve translations for Traditional Chinese.
go generate ./...)docs/Config.md) have been updated if necessary