Skip to content

Fix diff display of custom pagers after screen mode change#5349

Merged
stefanhaller merged 2 commits intomasterfrom
fix-diff-display-after-screen-mode-change
Mar 9, 2026
Merged

Fix diff display of custom pagers after screen mode change#5349
stefanhaller merged 2 commits intomasterfrom
fix-diff-display-after-screen-mode-change

Conversation

@stefanhaller
Copy link
Collaborator

We need to re-render the main view after a screen mode change, in case a custom pager is being used and its output depends on the window width.

@stefanhaller stefanhaller added the bug Something isn't working label Mar 8, 2026
@codacy-production
Copy link

codacy-production bot commented Mar 8, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b05e33d1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b05e33d) Report Missing Report Missing Report Missing
Head commit (5b23f80) 60202 52682 87.51%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5349) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@stefanhaller stefanhaller force-pushed the fix-diff-display-after-screen-mode-change branch from d9904f2 to de45cfc Compare March 9, 2026 07:19
@stefanhaller stefanhaller marked this pull request as ready for review March 9, 2026 07:20
This is needed for diffs in case a custom pager is used and its output depends
on the window width (e.g. the horizontal lines in delta).
@stefanhaller stefanhaller force-pushed the fix-diff-display-after-screen-mode-change branch from de45cfc to 5b23f80 Compare March 9, 2026 18:42
@stefanhaller stefanhaller enabled auto-merge March 9, 2026 18:42
@stefanhaller stefanhaller merged commit 43fa7a4 into master Mar 9, 2026
13 checks passed
@stefanhaller stefanhaller deleted the fix-diff-display-after-screen-mode-change branch March 9, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant