Skip to content

Security fix: avoid using ${{ }} variable interpolation in run: steps#5487

Merged
stefanhaller merged 1 commit intojesseduffield:masterfrom
orbisai0security:fix-fix-github-actions-shell-injection-release-yml
Apr 8, 2026
Merged

Security fix: avoid using ${{ }} variable interpolation in run: steps#5487
stefanhaller merged 1 commit intojesseduffield:masterfrom
orbisai0security:fix-fix-github-actions-shell-injection-release-yml

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix high severity security issue in .github/workflows/release.yml.

Vulnerability

Field Value
ID yaml.github-actions.security.run-shell-injection.run-shell-injection
Severity HIGH
Scanner semgrep
Rule yaml.github-actions.security.run-shell-injection.run-shell-injection
File .github/workflows/release.yml:113

Description: Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

Changes

  • .github/workflows/release.yml

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

…tion security vulnerability

Automated security fix generated by Orbis Security AI
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@stefanhaller stefanhaller changed the title fix: using variable interpolation `${{ in release.yml... Security fix: avoid using ${{ }} variable interpolation in run: steps Apr 8, 2026
@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Apr 8, 2026
@stefanhaller
Copy link
Copy Markdown
Collaborator

Thanks. I disagree that this is a high severity security issue, because an attacker would need push access to exploit it. Still good practice to fix it of course. Merging.

@stefanhaller stefanhaller enabled auto-merge April 8, 2026 08:19
@stefanhaller stefanhaller merged commit 84b7d1e into jesseduffield:master Apr 8, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants