[BUG] GitHub sync on Windows only works when pulling, not when pushing

[Kuret]

On Windows, GitHub sync only seems to work when receiving, not when sending after closing.

For example, if I close Zen on my Macbook, I correctly see the notification of it syncing on my Mac, and then the notification on my Windows machine that it pulled this.

However, if I then browse a bit on my Windows machine, and close Zen, no notification triggers, and if I check my Macbook, it didn't receive the tabs I opened on Windows. When I manually click the sync button from the taskbar it does work.

Maybe semi-related: If i reboot my windows machine, I get the button to sign in to GitHub again, like it's not signed in anymore, however I am still receiving pushes from my Macbook anyways.

Let me know what you'd need to debug this.

[jessewallace]

Fixed in v0.4.2-beta.1. Root cause: on Windows, sysinfo returns process names with a .exe suffix (zen.exe), but the running-check only matched zen, zen browser, and zen-* — so it always returned false, and auto-push on Zen close never triggered. The fix normalises the name before matching. Manual sync was unaffected because it bypasses that check entirely.

If you're able to test the beta, please let us know if this resolves the issue — we'll ship the stable release once confirmed.

[Kuret]

Awesome, thanks for the quick fix. I'll try it out when I get home tonight and get back to you.

[Kuret]

Just downloaded the beta, seems to work fine both ways now!