Fix NoMethodError when access_token is nil in callback_phase #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes omniauth#160 -
NoMethodError: undefined method 'expired?' for nil:NilClasswhen OAuth2 authentication fails andbuild_access_tokenreturns nil.Changes
expired?call and fail gracefully with:invalid_credentialsinstead of crashingOAuth2::TimeoutErrorandOAuth2::ConnectionErrorconstant lookup with::prefixExample
Before:
After:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
coveralls.io/usr/bin/ruby3.2 ruby3.2 /home/REDACTED/work/omniauth-oauth2/omniauth-oauth2/vendor/bundle/ruby/3.2.0/bin/rspec(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.