Add guard to arguments

[tinovyatkin]

I'm getting an error cannot read property [0] of undefined point to arguments access here while using ESLint in VSCode, it seems like ESLint while running on incomplete code can call this with arguments undefined. Adding guard should fix that.

[thymikee]

Can you run eslint --fix and maybe adjust commit message?

@SimenB maybe we shouldn't fail the CI in such case as we can adjust the commit message before merging, or at least run it as a separate job

[SimenB]

This needs a test which fails without this change

[SimenB]

@thymikee Not sure I follow. commitlint runs separately already, so it just fails the whole build, it doesn't stop the next script from running. We could (and maybe should) separate lint and test though, so one can see test output even if lint fails 🙂

[thymikee]

We could (and maybe should) separate lint and test though, so one can see test output even if lint fails 🙂

This is what I meant 👍

[SimenB]

911bba1

[SimenB]

@tinovyatkin ping 🙂Just adding a code snippet which shows the error you got would be great!

[steelbrain]

eslint-plugin-jest is crashing for me at expect(undefined).toBe on v22.0.1
I think this PR will fix it

The stack trace of the failure is

TypeError: Cannot read property '0' of undefined
at argument (node_modules/eslint-plugin-jest/rules/util.js:76:54)
at expectToBeCase (node_modules/eslint-plugin-jest/rules/util.js:34:3)
...

[SimenB]

Great, thanks @steelbrain! Those indeed reproduced the issue, and the change in this PR fixes it. I added that as an assertion and will merge when CI is happy 🙂

[SimenB]

🎉 This PR is included in version 22.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀