Remove global mock caches. #934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@facebook-github-bot import |
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Closed
ghost
pushed a commit
that referenced
this pull request
Apr 26, 2016
Summary: Fixes #935 and a bug I introduced in #934. I also updated it so that `fastpath` is only used in Node < 5. Node 5.7 and upwards have a fast implementation of the `path` module, so it should no longer be necessary then. Closes #937 Reviewed By: kentaromiura Differential Revision: D3223697 fb-gh-sync-id: c5010985d5608ed012b99a272d6d45a47514c0c3 fbshipit-source-id: c5010985d5608ed012b99a272d6d45a47514c0c3
ghost
pushed a commit
that referenced
this pull request
Apr 27, 2016
Summary: We removed global mock caches in #934 but for some reason I forgot to move this cache in the constructor. We only unmock the setup files a single time which isn't useful for subsequent tests. This makes it so we do this every time. It shouldn't have a big perf impact. Closes #942 Differential Revision: D3229346 fb-gh-sync-id: f58a2b5cc65160c2d0a63e874bb9257d3218f1a6 fbshipit-source-id: f58a2b5cc65160c2d0a63e874bb9257d3218f1a6
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #914.
This cache was added for performance but we have since made other optimizations and these global caches can now be local in the
Runtimeinstances again.Test Plan:
a couple of full test runs on www.