Skip to content

Conversation

@cpojer
Copy link
Member

@cpojer cpojer commented Apr 27, 2016

In #905 it was reported that people without mercurial had some trouble with jest -o. I fixed that initially but on some system it seems like childProcess.spawn can throw. It doesn't seem to happen on OS X locally but based on what I read about childProcess.spawn I do believe it can throw. I think it is best to wrap it in a try-catch now – the worst thing that can happen is to report back as not a git or not an hg repo, which it won't be if the commands fail.

I also took a note to write an integration test for this, now that we have integration tests. I will add a few in a follow up.

Test Plan:
Run jest -o with changed files both in a git and hg repo.

@cpojer
Copy link
Member Author

cpojer commented Apr 27, 2016

@facebook-github-bot import

@ghost ghost added the CLA Signed ✔️ label Apr 27, 2016
@ghost
Copy link

ghost commented Apr 27, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@cpojer cpojer mentioned this pull request Apr 27, 2016
@ghost ghost closed this in a3d30de Apr 27, 2016
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant