Revert #138 CanConvert widening; replace with workaround example#144
Open
Revert #138 CanConvert widening; replace with workaround example#144
Conversation
|
|
…ctory workaround Agent-Logs-Url: https://github.com/jet/FsCodec/sessions/e652c94e-4947-4dcc-9375-42b68ad34629 Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor UnionConverter to use derived type for custom logic
Revert #138 CanConvert widening; replace with workaround example
Mar 27, 2026
…ing) Agent-Logs-Url: https://github.com/jet/FsCodec/sessions/abdab0a0-9730-4095-9f8c-43244f505065 Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Collaborator
…section Agent-Logs-Url: https://github.com/jet/FsCodec/sessions/4d303594-0fa7-46cf-9aae-673d757c4f56 Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#138 widened
UnionConverter<'T>.CanConvertto accept nested case types (t.DeclaringType = typeof<'T>) to support serializing boxed DUs. This is not recommended practice from an STJ perspective and shouldn't live in the library.src/FsCodec.SystemTextJson/UnionConverter.fs: RevertCanConvertto pre-Fix UnionConverter.CanConvert for boxed multi-case DU #138 form:t = typeof<'T> && FsCodec.Union.isUnion ttests/.../UnionConverterTests.fs: Replace directUnionConverterusage with a localBoxedUnionConverterFactory<'T>that carries the widenedCanConvertlogic, serving as a copyable workaround exampleUsers needing boxed DU serialization can derive a custom factory:
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.