Skip to content

Conversation

@stephen-hero
Copy link
Contributor

No description provided.

@stephen-hero stephen-hero requested a review from sofiiako July 30, 2021 13:01
Copy link
Contributor

@sofiiako sofiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Here's a couple of tiny suggestions

This displays `1 2`.

For-loops translate similarly to for-expressions, but using the
*For* loops translate similarly to *for* expressions but use the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be better to enclose these in backtick quotes `` so that it is highlighted as code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I thought about it. Will fix it.

- `T` is contravariant and appears only as a method parameter type
- `U` is covariant and appears only as a method result type

So the method is checks out OK.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe what they wanted to write was "So the method checks out OK", no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought a lot about this one, too. Just was not sure that "the method checks out OK" is quite idiomatic. But if it sounds ok to you, let's have it this way!

A >: Reptile

The type parameter `A` that can range only over *supertypes* of `Reptile`.
The type parameter `A` can range over only the *supertypes* of `Reptile`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "The type parameter A can range only over the supertypes of Reptile." ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I guess you're right.

methods (`filter`, `flatMap`...) are implemented in a way where the head is not being evaluated if is
not explicitly indicated.
methods (`filter`, `flatMap`, etc.) are implemented in a way where the head is not evaluated unless it is
explicitly required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep 'indicated' here at the end....
Also, could you please add `` to LazyList and `Stream` at the beginning of this paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, will do that.

@sofiiako sofiiako merged commit 4be89d8 into master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants