Skip to content

[envsec] fix ls envname bug #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

[envsec] fix ls envname bug #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b434511
Fixed envname case mismatch
mohsenari Aug 30, 2023
f3bfc25
Updated missed envName
mohsenari Aug 30, 2023
0c0e0ac
Changed hardcoded env names to lowercase
mohsenari Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions envsec/internal/envcli/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ func execCmd() *cobra.Command {
commandToRun := exec.Command("/bin/sh", "-c", commandString)

// Default environment to fetch values from is DEV
envNames := []string{"DEV"}
envNames := []string{"dev"}
// If a specific environment was set by the user, then just use that one.
if cmd.Flags().Changed(environmentFlagName) {
envNames = []string{cmdCfg.EnvId.EnvName}
envNames = []string{strings.ToLower(cmdCfg.EnvId.EnvName)}
}
envId := envsec.EnvId{
OrgId: cmdCfg.EnvId.OrgId,
Expand Down
8 changes: 5 additions & 3 deletions envsec/internal/envcli/ls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
package envcli

import (
"strings"

"github.com/pkg/errors"
"github.com/spf13/cobra"
"go.jetpack.io/envsec"
Expand Down Expand Up @@ -32,18 +34,18 @@ func listCmd() *cobra.Command {
return err
}
// Populate the valid Environments
envNames := []string{"DEV", "PROD", "STAGING"}
envNames := []string{"dev", "prod", "staging"}
// If a specific environment was set by the user, then just use that one.
if cmd.Flags().Changed(environmentFlagName) {
envNames = []string{cmdCfg.EnvId.EnvName}
envNames = []string{strings.ToLower(cmdCfg.EnvId.EnvName)}
}

// TODO: parallelize
for _, envName := range envNames {
envId := envsec.EnvId{
OrgId: cmdCfg.EnvId.OrgId,
ProjectId: cmdCfg.EnvId.ProjectId,
EnvName: envName,
EnvName: strings.ToLower(envName),
}
envVars, err := cmdCfg.Store.List(cmd.Context(), envId)
if err != nil {
Expand Down