[envsec] fix ls envname bug #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipince
approved these changes
Aug 30, 2023
mikeland73
requested changes
Aug 31, 2023
Contributor
mikeland73
left a comment
mikeland73
left a comment
There was a problem hiding this comment.
Can we hold off on the backward incompatible changes until we have a plan for schema?
mikeland73
approved these changes
Aug 31, 2023
Contributor
mikeland73
left a comment
mikeland73
left a comment
There was a problem hiding this comment.
On second view, this won't break backwards compatibility because launchapad uses envsec as a library and not a CLI.
This means that:
- envsec the library is case sensitive.
- envsec the CLI tool is case insensitive (and stores everything lowercase).
I think this is OK.
Could you also modify the hard coded envNames (in exec.go and ls.go) to be all lower case?
mikeland73
added a commit
that referenced
this pull request
Oct 11, 2023
## Summary For launchpad to update we need: * Allow bootsrapping of a specific envID * Don't check if flag has changed in the commands themselves. * Remove `ToLower` Introduced in #118. This means envsec will be case sensitive. Note that the comments in that PR are not strictly correct, most commands do not do `ToLower` on environment, only `ls` and `exec` did. ## How was it tested? Compiled launchpad with updated version of envsec and tested envsec commands (set, ls, exec, rm)
jetpack-io-bot
pushed a commit
to jetify-com/envsec
that referenced
this pull request
Oct 11, 2023
## Summary For launchpad to update we need: * Allow bootsrapping of a specific envID * Don't check if flag has changed in the commands themselves. * Remove `ToLower` Introduced in jetify-com/opensource#118. This means envsec will be case sensitive. Note that the comments in that PR are not strictly correct, most commands do not do `ToLower` on environment, only `ls` and `exec` did. ## How was it tested? Compiled launchpad with updated version of envsec and tested envsec commands (set, ls, exec, rm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All envsec commands (except
lsandexec) usestrings.ToLower()when passingEnvId.EnvNamethat means environments like "DEV" and "PROD" becomes "dev" and "prod" in aws ssm.This creates a bug where you can set a secret with
envsec set key=valuebut inenvsec lsnot be able to see that key. This change might be backwards incompatible, but I don't know how envsec at its current state is usable unless someone specifies the environment everytime theysetandlsHow was it tested?
envsec set testkey=testvalueenvsec ls