[easy][envsec] Fix env case #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mikeland73 please see #118 when we use |
Contributor
|
Also, FWIW, i prefer lowercase |
Contributor
Author
|
@mohsenari #118 is backwards incompatible. The bug you ran into is that the default flag for environment is @ipince I agree lower case is better. We're just working out how to do it while continuing to support launchpad. |
Contributor
Author
|
Closing in favor of #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not sure we wanna keep uppercase, but for now this needs to match the default.
How was it tested?