Add SKU-aware OTA release artifacts#56
Merged
adamshiervani merged 6 commits intodevfrom Apr 27, 2026
Merged
Conversation
Persist OTA artifact URL/hash data separately from rollout state so stable release responses can choose artifacts by compatible SKU while release rollout remains version/type based.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Ensure stable release selection only considers releases with artifacts compatible with the requested SKU, and tighten tests around the DB-backed OTA contract.
| compatibleSkus: artifactData.compatibleSkus, | ||
| }, | ||
| create: artifactData, | ||
| }); |
There was a problem hiding this comment.
Exported setRollout helper is now unused dead code
Low Severity
The setRollout function was modified in this PR to add ReleaseArtifact creation logic, but its only consumer (releases.test.ts) removed the import in this same commit. A grep for setRollout across the test directory confirms the sole match is the definition in setup.ts. The newly added artifact-upsert code inside it is unreachable dead code.
Reviewed by Cursor Bugbot for commit 9cd63a1. Configure here.
Only expose stable signature URLs that actually exist and preserve production's version-first SKU error behavior.
Pre-SKU artifacts (no skus/ folder) are jetkvm-v2 only. Marking them compatible with jetkvm-v2-sdmmc would brick devices that received firmware predating their hardware. Future SKUs must opt in via an explicit skus/<sku>/ upload. sync-releases now skips releases already in the DB instead of upserting them. This prevents routine sync runs from rewriting Release.url/hash or appending duplicate ReleaseArtifact rows if R2_CDN_URL ever changes. Backfills and repairs are left to one-off scripts.
The flag is no longer sent by any client. Routine update checks now always go through the rollout-aware default-and-latest path, which is what forceUpdate effectively short-circuited to. Removes one query parameter, one branch in the handler, and the corresponding axis from the compare-releases sweep.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 57ec20b. Configure here.
getDefaultRelease previously picked the newest 100%-rolled-out release without checking SKU compatibility. If that release lacked a compatible artifact, the request 404'd downstream even though older 100%-rolled-out releases had valid binaries for the SKU. It now filters to releases that actually ship a compatible artifact before selecting the latest, falling back to a 404 only when no compatible default exists. The four DB lookups in the stable rollout-aware path are independent; run them concurrently so background-check latency drops from ~4 round trips to ~1.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseArtifactpersistence with migration backfill so release rollout remains onReleasewhile URL/hash artifacts are selected by compatible SKU./releasesand stable pinned/version-constrained responses to DB-backed artifact selection; prerelease and recovery/latest redirects continue using S3 where intended.Test plan
npm exec prisma generatenpm test -- test/releases.test.tsnpm run buildNote
High Risk
High risk because it introduces a new
ReleaseArtifacttable with backfill and rewires stable/releasesselection logic (including rollout/default behavior) to be DB-driven and SKU-filtered, which directly affects OTA update delivery. Sync tooling also now controls what stable releases appear in the DB, so data correctness and migration/sync runs are critical.Overview
Adds SKU-aware release artifacts. Introduces a new Prisma
ReleaseArtifactmodel/table linked toRelease, backfilled from existingReleaserows and marking legacy artifacts as compatible only withjetkvm-v2.Changes stable OTA resolution to be DB-backed and SKU-filtered. Stable
/releasesrequests now select URL/hash fromReleaseArtifactrows compatible with the requestedsku, apply rollout/default logic using DB data only, and compute optional.sigURLs by probing S3 based on the chosen artifact URLs; prerelease/releasescontinues to resolve from S3.Adds operational tooling and updates tests. Adds
scripts/sync-releases.ts(andnpm run sync-releases) to import stable releases/artifacts from S3 into the DB without mutating existing rows, plusscripts/compare-releases.shto diff local vs prod release endpoints; tests/seeding are updated to createReleaseArtifactrecords and validate the new DB-backed contract, and Vitest parallelism is disabled.Reviewed by Cursor Bugbot for commit f7775a0. Bugbot is set up for automated code reviews on this repo. Configure here.