feat: Add detached window with optional toolbar and hostname display#1187
feat: Add detached window with optional toolbar and hostname display#1187adamshiervani merged 9 commits intojetkvm:devfrom
Conversation
|
|
|
|
This PR adds a "Detach" button to the top bar that when clicked opens a browser popup with minimal UI so the user can have multiple KVMs open with minimal distractions, without wasting space in the monitor. 
|
tvinhas
force-pushed
the
detach-window
branch
2 times, most recently
from
5a2c9a2 to
70f8418
Compare
adamshiervani
left a comment
adamshiervani
left a comment
There was a problem hiding this comment.
Thanks for taking the time implementing this!
Overall feedback - can be much simpler and duplicate less code. The Action bar will get too crowded with another button, but I'll fix that once this is merged, as I need to rethink the entire navigation.
adamshiervani
left a comment
adamshiervani
left a comment
There was a problem hiding this comment.
- Opening the Virtual Media modal, will make it go away from detached mode
- Clicking on Connection Stats doesn't open the sidebar
Good catch! I never used neither of those functions so I didn't realize they were broken. Fixed both:
|
adamshiervani
left a comment
adamshiervani
left a comment
There was a problem hiding this comment.
Web Terminal doesn't work. Oddly enough, it works i you open the Virtual Media modal, but then the main big header pops up too.
Fixed both issues:
|
- Hide dotted background pattern in detached mode - Remove margins around video container - Remove min-width/height constraints and border/shadow on video
│
navigateTo() was dropping the ?detached=true query parameter during │
navigation, causing the Virtual Media modal to exit detached mode. │
The modal and sidebar containers were also hidden in detached mode │
via isDetachedWindow guards, preventing them from rendering. │
│
Fix navigateTo to preserve the detached query param across │
navigations, and remove the guards on Modal and SidebarContainer │
so both work in the detached window.
…mount route
The Terminal components were guarded by !isDetachedWindow, preventing
them from rendering. The mount route used raw navigate("..") which
drops the ?detached=true query param, causing the navbar to reappear
after closing the Virtual Media modal. Switched to navigateTo("/")
which preserves search params, and use the onClose callback for the
Dialog's internal navigation.
|
@adamshiervani I just rebased this against dev since you've been busy merging a lot of stuff to it. |
4 participants
Summary
Adds a "Detach" button to open the KVM video stream in a separate window. The detached window can optionally show/hide toolbars (configurable in Settings > Appearance), with the window size automatically adjusting. The window title
displays "JetKVM: {hostname}" for easy identification.
Checklist
make test_e2elocally and passed