fix(timesync): remove pool.ntp.org from default NTP servers#1301
Merged
adamshiervani merged 1 commit intojetkvm:devfrom Mar 17, 2026
Merged
fix(timesync): remove pool.ntp.org from default NTP servers#1301adamshiervani merged 1 commit intojetkvm:devfrom
adamshiervani merged 1 commit intojetkvm:devfrom
Conversation
pool.ntp.org requires vendor zone registration for use as a default in software or appliances. JetKVM has no vendor zone, so including it as a hardcoded fallback violates the NTP Pool's usage policy (https://www.ntppool.org/en/vendors.html). The remaining five hostname entries (time.apple.com, time.aws.com, time.windows.com, time.google.com, time.cloudflare.com) are vendor-operated services that explicitly permit public use. Combined with the 12 static IP entries for Cloudflare and Google, there is more than enough redundancy. Also removes a stale comment referencing a GitHub list of public NTP servers, since the fallback list is already curated. Closes jetkvm#698 Signed-off-by: Alex Howells <alex@howells.me>
adamshiervani
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #698
Problem
pool.ntp.orgis hardcoded inDefaultNTPServerHostnamesas afallback NTP server. The NTP Pool project's vendor policy
(https://www.ntppool.org/en/vendors.html) prohibits using the
default
pool.ntp.orgzone names in software or applianceswithout a registered vendor zone. JetKVM does not have one.
Fix
Remove
pool.ntp.orgfrom the fallback hostname list. Theremaining entries — five vendor-operated NTP services (Apple,
AWS, Microsoft, Google, Cloudflare) plus 12 static IPs for
Google and Cloudflare — provide sufficient redundancy. The sync
loop tries IPs first (no DNS dependency), then falls through to
hostnames, so removing one hostname from the end of the list has
negligible impact on sync reliability.
What this does NOT do
This does not register a vendor zone with the NTP Pool project.
If the maintainers want to use pool.ntp.org in future, they can
apply for a zone at https://manage.ntppool.org/manage/vendor and
add something like
0.jetkvm.pool.ntp.orgback to the list.