fix(webrtc): stop restricting ICE candidate gathering to mDNS net types#1307
Merged
adamshiervani merged 1 commit intodevfrom Mar 17, 2026
Merged
fix(webrtc): stop restricting ICE candidate gathering to mDNS net types#1307adamshiervani merged 1 commit intodevfrom
adamshiervani merged 1 commit intodevfrom
Conversation
… types SetNetworkTypes() controls which network types the ICE agent uses for ALL candidate gathering, not just mDNS. When mdns_mode was "ipv6_only", only UDP6 candidates were gathered — if IPv6 wasn't working, no candidates were gathered at all, making WebRTC connections impossible. Decouple mDNS mode from ICE network types so candidates are gathered on all available networks regardless of the mDNS configuration. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetNetworkTypes() controls which network types the ICE agent uses for ALL candidate gathering, not just mDNS. When
mdns_modewasipv6_only" only UDP6 candidates were gathered - if IPv6 wasn't working, no candidates were gathered at all, making WebRTC connections impossible.Decouple mDNS mode from ICE network types so candidates are gathered on all available networks regardless of the mDNS configuration.
Checklist
make test_e2elocally and passedCloses #<issue-number>)