feat(ota): include device SKU in update requests#1429
Merged
adamshiervani merged 2 commits intodevfrom Apr 25, 2026
Merged
Conversation
Read /etc/jetkvm-sku at startup and pass the value as a sku query parameter when checking for OTA updates, enabling the cloud API to serve variant-specific firmware for jetkvm-v2 (eMMC) and jetkvm-v2-sdmmc hardware. Falls back to "jetkvm-v2" when the file is absent for backwards compatibility. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e0f6ef6. Configure here.
The background auto-update loop in main.go also constructs UpdateParams and was missing the SKU field, so periodic updates would not transmit the device SKU to the cloud API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamshiervani
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Read /etc/jetkvm-sku at startup and pass the value as a sku query parameter when checking for OTA updates, enabling the cloud API to serve variant-specific firmware for jetkvm-v2 (eMMC) and jetkvm-v2-sdmmc hardware. Falls back to "jetkvm-v2" when the file is absent for backwards compatibility.
Please go to the
Previewtab ☝️ and select the appropriate sub-template:Note
Medium Risk
Changes OTA update-check request semantics by adding a new
skuquery parameter derived from device filesystem state, which could affect update eligibility/targeting if misread or misconfigured. Fallback behavior reduces risk, but cloud/server expectations and rollout should be validated.Overview
Adds device SKU detection via
GetDeviceSKU()(reads/etc/jetkvm-sku, defaults tojetkvm-v2) and threads it through OTA flows.OTA update URL generation now includes an optional
skuquery parameter, and all update checks/trigger paths (auto-update loop and RPC-driven status/update calls) populateota.UpdateParams.SKUso the release API can serve variant-specific firmware.Reviewed by Cursor Bugbot for commit 03d0e7a. Bugbot is set up for automated code reviews on this repo. Configure here.