Skip to content

feat(ota): include device SKU in update requests#1429

Merged
adamshiervani merged 2 commits intodevfrom
feat/ota-sku
Apr 25, 2026
Merged

feat(ota): include device SKU in update requests#1429
adamshiervani merged 2 commits intodevfrom
feat/ota-sku

Conversation

@chemhack
Copy link
Copy Markdown
Contributor

@chemhack chemhack commented Apr 25, 2026

Read /etc/jetkvm-sku at startup and pass the value as a sku query parameter when checking for OTA updates, enabling the cloud API to serve variant-specific firmware for jetkvm-v2 (eMMC) and jetkvm-v2-sdmmc hardware. Falls back to "jetkvm-v2" when the file is absent for backwards compatibility.

Please go to the Preview tab ☝️ and select the appropriate sub-template:


Note

Medium Risk
Changes OTA update-check request semantics by adding a new sku query parameter derived from device filesystem state, which could affect update eligibility/targeting if misread or misconfigured. Fallback behavior reduces risk, but cloud/server expectations and rollout should be validated.

Overview
Adds device SKU detection via GetDeviceSKU() (reads /etc/jetkvm-sku, defaults to jetkvm-v2) and threads it through OTA flows.

OTA update URL generation now includes an optional sku query parameter, and all update checks/trigger paths (auto-update loop and RPC-driven status/update calls) populate ota.UpdateParams.SKU so the release API can serve variant-specific firmware.

Reviewed by Cursor Bugbot for commit 03d0e7a. Bugbot is set up for automated code reviews on this repo. Configure here.

Read /etc/jetkvm-sku at startup and pass the value as a sku query
parameter when checking for OTA updates, enabling the cloud API to
serve variant-specific firmware for jetkvm-v2 (eMMC) and
jetkvm-v2-sdmmc hardware. Falls back to "jetkvm-v2" when the file
is absent for backwards compatibility.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 25, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e0f6ef6. Configure here.

Comment thread ota.go
The background auto-update loop in main.go also constructs UpdateParams
and was missing the SKU field, so periodic updates would not transmit
the device SKU to the cloud API.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@adamshiervani adamshiervani merged commit eb56468 into dev Apr 25, 2026
5 checks passed
@adamshiervani adamshiervani deleted the feat/ota-sku branch April 25, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants