Add explicit USB wake control#1471
Merged
Merged
Conversation
976f78b to
3d5ecd4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d5ecd4. Configure here.
3d5ecd4 to
5b16004
Compare
5b16004 to
913ece1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a no-signal
Try to wakecontrol that sends a dedicated wake-only HID signal, while regular keyboard and mouse reports stay blocked during suspend or no-signal states.Covers the behavior with S3 E2E tests for both ignored browser input and successful button-triggered wake, with the full E2E suite passing.
Note
Medium Risk
Adds a new
wakeHostRPC that drives a dedicated wake-capable HID function and changes HID wake settings, which can impact suspend/resume behavior and USB gadget enumeration.Overview
Adds an explicit USB wake path by introducing a dedicated vendor HID function (
wake_hidon/dev/hidg3) withwakeup_on_write=1, while disablingwakeup_on_writefor the normal keyboard and mouse HID functions.Exposes this via a new JSON-RPC method
wakeHost(toggling the wake report a few times) and wires it to a new “Try to wake” button on the no-signal video overlay (with new localized strings).Updates E2E coverage to validate S3 behavior: browser/regular HID input does not wake the host, and waking works via the overlay button and the explicit
wakeHostRPC; remote-agenthealth()now supports a timeout to make these checks more reliable.Reviewed by Cursor Bugbot for commit 913ece1. Bugbot is set up for automated code reviews on this repo. Configure here.