feat: add idle host display setting#1476
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit afd04c8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #901, #975, #233
Summary
Note
Medium Risk
Changes HDMI EDID/HPD and session lifecycle behavior on the host; regressions could affect display enumeration, EDID presets, or reconnect UX, though logic includes rollback and e2e coverage.
Overview
Adds an optional hide JetKVM display when idle flow: when enabled and no remote WebRTC sessions are active, the device stops advertising HDMI EDID (clears EDID / drops HPD) so the host no longer sees JetKVM as a monitor; EDID is restored when the first session connects, on native restart, and when EDID or idle settings change.
Backend wires this through
HideDisplayWhenIdleconfig, session hooks inwebrtc.go, centralizedapplyHostDisplayAdvertisement/reapplyHostDisplayAdvertisementinvideo.go, aDisabledEDIDsentinel, zero-size EDID support in native/CGO, and JSON-RPCgetHostDisplayIdleMode/setHostDisplayIdleModewith safersetEDIDrollback. The video settings UI adds a checkbox; WebRTC video adds a short startup grace before showing HDMI errors after hotplug cycles.E2E covers host connector visibility across idle vs active sessions; strings added for all locales.
Reviewed by Cursor Bugbot for commit 2433b02. Bugbot is set up for automated code reviews on this repo. Configure here.