Stabilize remote agent input E2E tests#1477
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32f16f2. Configure here.
| callJsonRpc(sharedPage, "setUsbConfig", { usbConfig: defaultConfig }).catch(() => { | ||
| /* ignore */ | ||
| }); | ||
| await setUsbConfigAndWait(defaultConfig, ID_DEFAULT); |
There was a problem hiding this comment.
USB test timeout budget overrun
Medium Severity
The USB presence test chains multiple setUsbDevicesAndWait and setUsbConfigAndWait calls. Each of these operations can take up to ~55 seconds, but the overall Playwright test timeout is still the default 60 seconds. This can cause the test to time out and fail if several re-enumeration steps are slow, even if they would eventually succeed.
Reviewed by Cursor Bugbot for commit 32f16f2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes remote-agent E2E coverage by polling for host-visible USB reconfiguration instead of relying on the browser-side RPC timeout. It also primes absolute mouse movement before assertions so the first checked move cannot be swallowed as a no-op.
Note
Low Risk
Changes are limited to Playwright E2E helpers and assertions; no production USB, RPC, or UI runtime code is modified.
Overview
Remote-agent E2E tests in
ra-all.spec.tsare hardened against slow USB gadget rebinds and flaky mouse assertions.New helpers
setUsbDevicesAndWaitandsetUsbConfigAndWaitissuesetUsbDevices/setUsbConfigover JSON-RPC but treat a browser-side RPC timeout as non-fatal, then poll the remote agent until the host shows the expected input device types or USB VID/PID. That pattern replaces barecallJsonRpc+ shorter waits in the relative-only wheel cleanup and the USB presence/switching/descriptor test, including a proper await when restoring the default USB descriptor (instead of a fire-and-forget call).The absolute mouse movement test primes corner/center moves and waits for at least one visible move before clearing events, so a pointer already at the target cannot make the first “center” assertion a no-op.
Reviewed by Cursor Bugbot for commit 32f16f2. Bugbot is set up for automated code reviews on this repo. Configure here.