feat(ci): GitHub action for pull requests - Go + NodeJS#189
Closed
timothystewart6 wants to merge 1 commit intojetkvm:devfrom
Closed
feat(ci): GitHub action for pull requests - Go + NodeJS#189timothystewart6 wants to merge 1 commit intojetkvm:devfrom
timothystewart6 wants to merge 1 commit intojetkvm:devfrom
Conversation
Contributor
Author
|
After this is merged it should be added to the pull request status checks so it enforces the build to pass. |
IDisposable
approved these changes
May 8, 2025
Contributor
|
Thanks, Tim. We had to implement our own custom solution using a testing suite in a private repo in order to run tests on real devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request action that will build the Go app and build the NodeJS app to ensure no one breaks the build. It also caches dependencies for both go and NodeJS.
This would also be a good place to run linting and tests however it hasn't been run in the past so there's a lot to clean up. Added it but commented it out.
I already added this to my fork and you can see the output here:
https://github.com/timothystewart6/kvm/actions/runs/13490998649