Skip to content

Conversation

@jackislanding
Copy link
Contributor

@jackislanding jackislanding commented Jan 24, 2025

resolves #15

A new button is added to configure the USB Emulation.

USB descriptors can now be modified, and a successful configuration rebinds the USB Device.

USB Device ID Examples:

Before:

Shows the default JetKVM Descriptors

image

After:

@JoveToo
Copy link

JoveToo commented Jan 29, 2025

Why would you allow for jetkvm to just take a random usb vid/pid? Those are assigned, not to be chosen randomly.

@Nevexo
Copy link
Contributor

Nevexo commented Jan 29, 2025

Why would you allow for jetkvm to just take a random usb vid/pid? Those are assigned, not to be chosen randomly.

JetKVM doesn't have its own VID/PID, it uses the generic Linux Foundation Composite Device.

As for why? Some people want to hide the KVM. While I can't think of a legitimate reason for doing so, a lot of people ask for it. And besides, the KVM will always be detectable, even if someone fudges with the VID/PID

@jackislanding
Copy link
Contributor Author

jackislanding commented Jan 29, 2025

Why would you allow for jetkvm to just take a random usb vid/pid? Those are assigned, not to be chosen randomly.

Many people have asked for the feature, and since I have knowledge of how the usb gadget framework works, I went ahead and took a crack at it.

I'm assuming it's a pretty valuable feature, and since the competition have it, I figured JetKVM should have a leg up.

@adamshiervani
Copy link
Contributor

I’d love to see a dropdown with preconfigured USB options, similar to what we did with EDID. With EDID for example, most users will not fully understand how it works, but they grasp the general concept and will try fiddle with available options. I suspect the same thing applies here.

@jackislanding
Copy link
Contributor Author

@adamshiervani sounds good, what do you think about adding existing consumer devices and naming them as such?

Or should we have generic devices?

@adamshiervani
Copy link
Contributor

I'd say let's just add 3-5 consumer devices that are commonly used. All other use cases get to customize their own.

Additionally, in the description of the modal, we could also link to some website where they can look their specific values.

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@adrianmeraz
Copy link
Contributor

@adamshiervani I'm ready to have this PR reviewed again

There is now a dropdown showing preconfigured options

image

When settting the config, a notifcation shows the user that the change has been successful

image

When selecting "custom", the button to manually set parameters appears:

image

Clicking the button shows the fields that can be set:

image

@adrianmeraz
Copy link
Contributor

@adamshiervani The custom fields dialog also has a link to lookup the VID and PID.

image

It builds a query to the "the-sz.com" site to lookup IDs.

Below is an example url + query:

https://the-sz.com/products/usbid/index.php?v=0x413c&p=0x2011

@Nevexo
Copy link
Contributor

Nevexo commented Feb 20, 2025

Looking great, I'll have a read through in a moment but you'll likely need to rebase this on dev as the config struct has moved along a fair bit since this PR started.

@adrianmeraz
Copy link
Contributor

adrianmeraz commented Feb 21, 2025

Understood, I'm unsure of how to rebase on another branch from my repo.

When trying to rebase, it just keeps going in an infinite loop of trying to merge conflicts.

@adrianmeraz
Copy link
Contributor

Nevermind, it's been rebased. Check out PR #185

@chemhack
Copy link

Closing in favour of #185

@chemhack chemhack closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability Override the Jet KVM USB ids to look like common brands for Mouse and Keyboard

8 participants