Remove commit hash from Version string

[nalum]

What this PR does / why we need it:
This PR removes the Git commit hash from the version string unless github.com/JetStack/cert-manager/pkg/util.AppVersion is set to canary.

Which issue this PR fixes: fixes #997

Special notes for your reviewer:
Open question on issue #997.

Release note:

Removed the Git commit hash from the version string in non `canary` builds (#997)

[munnerz]

/ok-to-test

[munnerz]

(copying your question over from the issue):

👍 @munnerz Is this something that should be applied to the version string in general or just the user agent?
While tags are a pointer to a specific commit there is the possibility that a tag has been moved (for what ever reason) so maybe only applied to the user agent string.

I think applying it to the version in general should suffice. We won't be changing git tags after they are created, and if we do, presumably there is a very good reason and the other version has not rolled out yet.

Let's go with how you've done it here, and if we start hitting issues we can adjust accordingly 😄

Thanks! This is perfect, and thanks also for the unit tests!

You'll need to run bazel run //hack:update-bazel and commit the change BUILD.bazel file in order to have this pass the codegen and unit checks 😄

/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [munnerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nalum]

@munnerz I will get on that as soon as I can 👍

[munnerz]

Thanks @nalum! I think a simple bazel run //hack:update-bazel should sort these errors out!

[munnerz]

Thanks again!

/lgtm