Godaddy dns provider

[ndemeshchenko]

What this PR does / why we need it:
Add Godaddy as a DNS01 provider

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

closes #1083

Special notes for your reviewer:

Release note:

Add Godaddy as a DNS01 provider

[jetstack-bot]

Hi @ndemeshchenko. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[agolomoodysaada]

@wallrj , this is blocking us as we would like to use wildcard certs with godaddy as the DNS provider.
Thank you so much for the PR @ndemeshchenko

[agolomoodysaada]

@wallrj , what do we need to do to get this PR approved?

[ndemeshchenko]

hi, @kragniz @munnerz @wallrj
can this get an ok-to-test please?

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ndemeshchenko
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kragniz

If they are not already assigned, you can assign the PR to them by writing /assign @kragniz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agolomoodysaada]

@ndemeshchenko , please signoff the DCO to get this merged

[ndemeshchenko]

hi, @kragniz @munnerz @wallrj
rebase is done.
can this get an ok-to-test again please?
Thanks

[alighm]

any update on this?! really would like to use it ASAP!

[jetstack-bot]

@ndemeshchenko: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[scones]

If i read this correctly, this branch was created, rebased, approved, time has passed, it had to be rebased again, it was rebased again, time has passed, it had to be rebased again, it was rebased again, time has passed, it had to be rebased again

could one of the team-members hit the merge button after the next rebase?

[munnerz]

This PR will not be merged into the repo in its current form - we have recently extended out the DNS provider code to allow for out of tree DNS providers, as we as a small development team are unable to maintain and manage automated testing for such a large number of DNS01 providers.

More info can be read here: https://groups.google.com/forum/#!topic/cert-manager-dev/CgoMxSP6DSI

This information should have been posted on this PR around the same time as being posted to the mailing list - it appears we missed this one!

I am intending to go through all DNS01 provider PRs over the next week or so, closing them and advising how someone can create their own DNS01 webhook provider. We currently have a working webhook 'example repo' here: https://github.com/jetstack/cert-manager-webhook-example, as well as a test suite that DNS provider developers can run against their own code to ensure their webhook is 'conformant'.

There will be better documentation produced for the new webhook code over the coming weeks too - this particular feature has been a long time coming, and probably should have been done a long time ago (there are upwards of 15 DNS provider PRs currently open against this repo!)

[scones]

thank you for pointing this out and clarifications :)

[ndemeshchenko]

@munnerz Thanks for your response.
it took you, guys, 7 month to post a response. Well done.

[nadilas]

Hi @ndemeshchenko, did you ever create a webhook version?