Skip to content

Enable PodSecurityPolicies in end-to-end tests#2280

Closed
munnerz wants to merge 1 commit into
cert-manager:masterfrom
munnerz:kind-enable-psp
Closed

Enable PodSecurityPolicies in end-to-end tests#2280
munnerz wants to merge 1 commit into
cert-manager:masterfrom
munnerz:kind-enable-psp

Conversation

@munnerz
Copy link
Copy Markdown
Member

@munnerz munnerz commented Oct 24, 2019

What this PR does / why we need it:

Enable PodSecurityPolicy admission controller during end-to-end tests.

This PR can be used as a basis to help test #2234 properly.

We'll probably need to bind a permissive PSP policy to all pods by default, and incrementally enable PSPs throughout.

Release note:

NONE

Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 24, 2019
@jetstack-bot jetstack-bot requested a review from JoshVanL October 24, 2019 18:56
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
@jetstack-bot
Copy link
Copy Markdown
Contributor

@munnerz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cert-manager-e2e-v1-15 cb738f4 link /test pull-cert-manager-e2e-v1-15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kri5 added a commit to kri5/cert-manager that referenced this pull request Nov 20, 2019
This kind of issue might be detected early in the future when enabling psp
in e2e tests (cert-manager#2280).

A similar bug was already fixed in
be0b865.

This commit fixes the typo.
kri5 added a commit to kri5/cert-manager that referenced this pull request Nov 20, 2019
This kind of issue might be detected early in the future when enabling psp
in e2e tests (cert-manager#2280).

A similar bug was already fixed in
be0b865.

This commit fixes the typo.

Signed-off-by: Christophe Courtaut <christophe.courtaut@gmail.com>
@munnerz munnerz closed this Jan 17, 2020
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Dec 18, 2022
This kind of issue might be detected early in the future when enabling psp
in e2e tests (cert-manager/cert-manager#2280).

A similar bug was already fixed in
282d9ef.

This commit fixes the typo.

Signed-off-by: Christophe Courtaut <christophe.courtaut@gmail.com>
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Apr 8, 2023
This kind of issue might be detected early in the future when enabling psp
in e2e tests (cert-manager/cert-manager#2280).

A similar bug was already fixed in
a0a71ef.

This commit fixes the typo.

Signed-off-by: Christophe Courtaut <christophe.courtaut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants