tests: allow setting DNSName and ChallengeKey for webhook integration tests#3770
tests: allow setting DNSName and ChallengeKey for webhook integration tests#3770jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
|
Hi @jonathansp. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jakexks |
…ration tests Signed-off-by: Jonathan Simon Prates <jonathan.simonprates@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, jonathansp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind feature |
|
/retest |
|
Thanks @jakexks. |
What this PR does / why we need it:
Custom webhooks provide a relatively easy approach to extend cert-manager acme-challenge to other DNS providers. Some in-house developed DNS providers/integrations may have restrictions, allowing just a few domains to be validated, and often example.com is not one of them.
This PR allows the base DNS name to be set using the new
SetDNSName()andSetDNSChallangeKey()methods in tests only. If not set, the default value "example.com" will be used, without changing the original behavior.