Skip to content

Comments

tests: allow setting DNSName and ChallengeKey for webhook integration tests#3770

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
jonathansp:master
Mar 15, 2021
Merged

tests: allow setting DNSName and ChallengeKey for webhook integration tests#3770
jetstack-bot merged 1 commit intocert-manager:masterfrom
jonathansp:master

Conversation

@jonathansp
Copy link
Contributor

@jonathansp jonathansp commented Mar 15, 2021

What this PR does / why we need it:

Custom webhooks provide a relatively easy approach to extend cert-manager acme-challenge to other DNS providers. Some in-house developed DNS providers/integrations may have restrictions, allowing just a few domains to be validated, and often example.com is not one of them.

This PR allows the base DNS name to be set using the new SetDNSName() and SetDNSChallangeKey() methods in tests only. If not set, the default value "example.com" will be used, without changing the original behavior.

NONE

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2021
@jetstack-bot jetstack-bot requested a review from SgtCoDFish March 15, 2021 11:23
@jetstack-bot jetstack-bot added area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2021
@jetstack-bot
Copy link
Contributor

Hi @jonathansp. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2021
@jonathansp
Copy link
Contributor Author

/assign @jakexks

…ration tests

Signed-off-by: Jonathan Simon Prates <jonathan.simonprates@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 15, 2021
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, jonathansp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2021
@jakexks
Copy link
Member

jakexks commented Mar 15, 2021

/kind feature
/milestone v1.3

@jetstack-bot jetstack-bot added this to the v1.3 milestone Mar 15, 2021
@jetstack-bot jetstack-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 15, 2021
@jakexks
Copy link
Member

jakexks commented Mar 15, 2021

/retest

@jetstack-bot jetstack-bot merged commit 0b4abcc into cert-manager:master Mar 15, 2021
@jonathansp
Copy link
Contributor Author

Thanks @jakexks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants