Skip to content

Conversation

@j-fuentes
Copy link
Member

This adds support for the new form of the endpoint that gathers data.

It introduces significant changes in the configuration, but everything should be backward compatible.

These changes are:

  • The Schedule field is not optional, as we are using the period flag at the moment.
  • The Token string is also optional, as it should not be specified when using OAuth2.
  • The Endpoint is being deprecated, as in the future you won't configure the endpoint for uploading data, just preflight server. At the moment it is still being used if specified, but ignored and defaulting to /api/v1/datareadings otherwise.
  • Added a new Server property that points to the Preflight server. Defaults to https://preflight.jetstack.io if not specified.
  • Added OrganizationID which will be used with the new endpoint.
  • Added ClusterID. To be left empty if using agent tokens (as they already point to a cluster).

Signed-off-by: Jose Fuentes jsfuentescastillo@gmail.com

@j-fuentes j-fuentes self-assigned this Apr 24, 2020
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 24, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2020
Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@charlieegan3
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@jetstack-bot jetstack-bot merged commit cb7733c into jetstack:master Apr 27, 2020
@j-fuentes j-fuentes deleted the support-new-gathering-endpoint branch April 27, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants