Skip to content

Pass oauth flags to docker build #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jetstack-bot merged 1 commit into from
May 12, 2020
Merged

Pass oauth flags to docker build #169

jetstack-bot merged 1 commit into from
May 12, 2020

Conversation

@j-fuentes
Copy link
Member

@j-fuentes j-fuentes commented May 8, 2020

Signed-off-by: Jose Fuentes jsfuentescastillo@gmail.com

@j-fuentes
Make docker build pass oauth flags
e0a08b3 
Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@j-fuentes j-fuentes requested a review from charlieegan3 May 8, 2020 08:16
@j-fuentes j-fuentes self-assigned this May 8, 2020
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label May 8, 2020
@jetstack-bot
Copy link
Contributor

jetstack-bot commented May 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2020
@charlieegan3
Copy link
Contributor

charlieegan3 commented May 11, 2020

After our discussion this morning, I think we're not going this route any more?

@j-fuentes
Copy link
Member Author

j-fuentes commented May 12, 2020

After our discussion this morning, I think we're not going this route any more?

Finally, we have opted to continue down this path and add the OAuth clientID and clientSecret to the Makefile. So this PR still applies.

@charlieegan3
Copy link
Contributor

charlieegan3 commented May 12, 2020

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@jetstack-bot jetstack-bot merged commit 9be6b19 into jetstack:master May 12, 2020
@j-fuentes j-fuentes deleted the docker-build-oauth-flags branch May 12, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlieegan3 charlieegan3 Awaiting requested review from charlieegan3

Assignees

@charlieegan3 charlieegan3

@j-fuentes j-fuentes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-fuentes @jetstack-bot @charlieegan3