Skip to content

Conversation

@j-fuentes
Copy link
Member

I broke the build by adding those constants with quotes to the Makefile.

Signed-off-by: Jose Fuentes jsfuentescastillo@gmail.com

Signed-off-by: Jose Fuentes <jsfuentescastillo@gmail.com>
@j-fuentes j-fuentes requested a review from charlieegan3 May 12, 2020 11:39
@j-fuentes j-fuentes self-assigned this May 12, 2020
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label May 12, 2020
@jetstack-bot jetstack-bot requested a review from wwwil May 12, 2020 11:39
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-fuentes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2020
@j-fuentes j-fuentes removed the request for review from wwwil May 12, 2020 11:39
@j-fuentes j-fuentes merged commit 60df3c0 into jetstack:master May 12, 2020
@j-fuentes j-fuentes deleted the fix-build branch May 12, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants