Skip to content

Add Olu to approvers list #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jetstack-bot merged 1 commit into from
Jul 30, 2020
Merged

Add Olu to approvers list #193

jetstack-bot merged 1 commit into from
Jul 30, 2020

Conversation

@charlieegan3
Copy link
Contributor

@charlieegan3 charlieegan3 commented Jul 30, 2020

No description provided.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Jul 30, 2020
@jetstack-bot jetstack-bot requested a review from j-fuentes July 30, 2020 09:59
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jul 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlieegan3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2020
@charlieegan3
Add olu to approvers list
efb99b1 
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 30, 2020
@charlieegan3
Copy link
Contributor Author

charlieegan3 commented Jul 30, 2020

@james-w can you /lgtm this?

(cc @tfadeyi)

@james-w
Copy link

james-w commented Jul 30, 2020

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@jetstack-bot jetstack-bot merged commit 7e87659 into jetstack:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-fuentes j-fuentes Awaiting requested review from j-fuentes

Assignees

@james-w james-w

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charlieegan3 @jetstack-bot @james-w