Remove basic auth from agent codebase #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes basic auth from the preflight client inialization. Still allows preflight client to be not auth. Related #414 Signed-off-by: Oluwole Fadeyi <tfadeyi@users.noreply.github.com>
tfadeyi
added
kind/cleanup
jetstack-bot
added
the
dco-signoff: yes
jetstack-bot
added
the
approved
Contributor
Author
|
@j-fuentes should we remove the token field from the agent's |
Member
Yes, we should, as it is useless now. |
j-fuentes
requested changes
Aug 13, 2020
Removed token field from agent config as it isn't used anymore. Related [#414] Signed-off-by: Oluwole Fadeyi <tfadeyi@users.noreply.github.com>
tfadeyi
force-pushed
the
414-basic-auth-agent
branch
from
3611121 to
a126ce5
Compare
j-fuentes
approved these changes
Aug 13, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: j-fuentes, tfadeyi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes basic auth from the preflight client inialization.
Still allows preflight client to be not auth.
Related #414
Signed-off-by: Oluwole Fadeyi tfadeyi@users.noreply.github.com