Skip to content

Update version checker data gatherer #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tfadeyi merged 1 commit into from
Nov 25, 2020
Merged

Update version checker data gatherer #210

tfadeyi merged 1 commit into from
Nov 25, 2020

Conversation

@tfadeyi
Copy link
Contributor

@tfadeyi tfadeyi commented Nov 24, 2020 •
edited
Loading

Updating version checker data gatherer to support multi-arch images.
This PR uses the packages from the https://github.com/jetstack/version-checker/tree/58-add-arch-and-os-checks
branch of version-checker.
With this change checks will be performed on the image for the correct architecture, so if node is amd64 the check is done on images with amd64. This won't fix the issues seen with fat manifests #58.
image

image

Signed-off-by: oluwole.fadeyi oluwole.fadeyi@jetstack.io

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 24, 2020

@tfadeyi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2020
@jetstack-bot jetstack-bot requested a review from wwwil November 24, 2020 16:48
@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2020
@tfadeyi tfadeyi force-pushed the update-version-checker branch 2 times, most recently from 41d3bd4 to 47cfc73 Compare November 25, 2020 12:12
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2020
@tfadeyi tfadeyi changed the title WIP: Update version checker data gatherer Update version checker data gatherer Nov 25, 2020
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2020
@tfadeyi tfadeyi requested review from charlieegan3 and j-fuentes and removed request for wwwil November 25, 2020 12:15
@tfadeyi tfadeyi force-pushed the update-version-checker branch from 47cfc73 to e38bd36 Compare November 25, 2020 12:16
charlieegan3
charlieegan3 reviewed Nov 25, 2020
View reviewed changes
charlieegan3
charlieegan3 reviewed Nov 25, 2020
View reviewed changes
charlieegan3
charlieegan3 reviewed Nov 25, 2020
View reviewed changes
@charlieegan3
Copy link
Contributor

charlieegan3 commented Nov 25, 2020

/lgtm
/hold

Looks good, pending a few minor comments.

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@tfadeyi tfadeyi force-pushed the update-version-checker branch from e38bd36 to 5a7de6a Compare November 25, 2020 14:23
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@charlieegan3
Copy link
Contributor

charlieegan3 commented Nov 25, 2020

/lgtm
/hold

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
j-fuentes
j-fuentes reviewed Nov 25, 2020
View reviewed changes
j-fuentes
j-fuentes reviewed Nov 25, 2020
View reviewed changes
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-fuentes, tfadeyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@j-fuentes
Copy link
Member

j-fuentes commented Nov 25, 2020

Looking good. Consider my suggestions.

/lgtm
/hold

Update version checker data gatherer
7be4cb8 
Updating vc gatherer to support multi-arch images

Signed-off-by: oluwole.fadeyi <oluwole.fadeyi@jetstack.io>
@tfadeyi tfadeyi force-pushed the update-version-checker branch from 5a7de6a to 7be4cb8 Compare November 25, 2020 16:10
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 25, 2020

New changes are detected. LGTM label has been removed.

@tfadeyi
Copy link
Contributor Author

tfadeyi commented Nov 25, 2020

Is it fine if merge this PR? Or should we keep it on hold for version-checker's release?

@j-fuentes
Copy link
Member

j-fuentes commented Nov 25, 2020

Is it fine if merge this PR? Or should we keep it on hold for version-checker's release?

Let's go ahead and merge this so we can beta-test this agent.

Once the changes are applied upstream in version-checker we can update the dependency.

@tfadeyi tfadeyi merged commit aca4bd3 into master Nov 25, 2020
@davidsbond davidsbond deleted the update-version-checker branch September 2, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-fuentes j-fuentes j-fuentes approved these changes

+1 more reviewer

@charlieegan3 charlieegan3 charlieegan3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@charlieegan3 charlieegan3

@j-fuentes j-fuentes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tfadeyi @jetstack-bot @charlieegan3 @j-fuentes