Add VenafiConnection CRD to discovery-agent Helm chart#814
Merged
Conversation
2fc56c0 to
3b39609
Compare
4508f19 to
42bda42
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
42bda42 to
07331b0
Compare
Contributor
Author
|
The e2e failures are unrelated to the changes in this PR (flakes + 403 WAF errors). |
davidnoyes
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new configuration options and resources to improve the management and deployment flexibility of the Venafi Connection within the Discovery Agent Helm chart. The main changes allow users to optionally include or exclude VenafiConnection CRDs and RBAC, specify the namespace for the Venafi service account, and ensure proper RBAC and CRD templating. Additionally, the Helm chart documentation, schema, and Makefile targets are updated to support these enhancements.
Venafi Connection configuration and templating:
venafiConnectionconfiguration block tovalues.yamland its schema, allowing users to control inclusion of VenafiConnection CRDs/RBAC and specify the service account namespace. [1] [2] [3] [4]CRD and Makefile updates:
Documentation and dependency updates:
README.mdto document the new Venafi Connection configuration options.klone.yamlto use a new hash for makefile-modules dependencies.