Skip to content

Add VenafiConnection CRD to discovery-agent Helm chart#814

Merged
inteon merged 1 commit into
masterfrom
discovery_agent_add_crd
Jun 4, 2026
Merged

Add VenafiConnection CRD to discovery-agent Helm chart#814
inteon merged 1 commit into
masterfrom
discovery_agent_add_crd

Conversation

@inteon
Copy link
Copy Markdown
Contributor

@inteon inteon commented Jun 3, 2026

This pull request introduces new configuration options and resources to improve the management and deployment flexibility of the Venafi Connection within the Discovery Agent Helm chart. The main changes allow users to optionally include or exclude VenafiConnection CRDs and RBAC, specify the namespace for the Venafi service account, and ensure proper RBAC and CRD templating. Additionally, the Helm chart documentation, schema, and Makefile targets are updated to support these enhancements.

Venafi Connection configuration and templating:

  • Added venafiConnection configuration block to values.yaml and its schema, allowing users to control inclusion of VenafiConnection CRDs/RBAC and specify the service account namespace. [1] [2] [3] [4]
  • Updated Helm templates to conditionally render VenafiConnection CRDs and RBAC based on the new config, and to use the specified service account namespace. [1] [2] [3]
  • Added templating helpers for VenafiConnection labels and chart naming.

CRD and Makefile updates:

  • Added conditional headers for CRD generation to support Kubernetes version differences and the new include logic. [1] [2] [3]
  • Updated Makefile logic to support new CRD generation and verification targets, ensuring proper sequencing and compatibility with the new Helm chart structure. [1] [2] [3] [4] [5] [6]

Documentation and dependency updates:

  • Expanded README.md to document the new Venafi Connection configuration options.
  • Updated klone.yaml to use a new hash for makefile-modules dependencies.

@inteon inteon force-pushed the discovery_agent_add_crd branch 9 times, most recently from 2fc56c0 to 3b39609 Compare June 4, 2026 08:01
@inteon inteon added test-e2e To signal e2e test job to be run test-ngts test-ark labels Jun 4, 2026
@inteon inteon closed this Jun 4, 2026
@inteon inteon reopened this Jun 4, 2026
@inteon inteon force-pushed the discovery_agent_add_crd branch 2 times, most recently from 4508f19 to 42bda42 Compare June 4, 2026 08:17
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the discovery_agent_add_crd branch from 42bda42 to 07331b0 Compare June 4, 2026 08:27
@inteon
Copy link
Copy Markdown
Contributor Author

inteon commented Jun 4, 2026

The e2e failures are unrelated to the changes in this PR (flakes + 403 WAF errors).

@inteon inteon merged commit e7a6c11 into master Jun 4, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-ark test-e2e To signal e2e test job to be run test-ngts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants