Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Write ssh config at tarmak initialisation to ensure present #247

Merged
merged 3 commits into from
May 22, 2018
Merged

Write ssh config at tarmak initialisation to ensure present #247

merged 3 commits into from
May 22, 2018

Conversation

@charlieegan3
Copy link
Contributor

@charlieegan3 charlieegan3 commented May 22, 2018 •
edited
Loading

Replaces: #189

Ensure ssh config for current cluster is present before running terraform commands

@jetstack-bot jetstack-bot requested a review from JoshVanL May 22, 2018 10:28
@jetstack-bot jetstack-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2018
@charlieegan3
Only write config before terraform commands
ba830ab 
Otherwise it writes the config whenever we create a new tarmak instance
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2018
@simonswine
Copy link
Contributor

Thanks @charlieegan3
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2018
@jetstack-ci-bot
Copy link
Contributor

Automatic merge from submit-queue.

@jetstack-ci-bot jetstack-ci-bot merged commit 98a8467 into jetstack:master May 22, 2018
This was referenced May 22, 2018
Closed
Closed
@charlieegan3 charlieegan3 mentioned this pull request May 22, 2018
Merged
jetstack-ci-bot added a commit that referenced this pull request May 22, 2018
@jetstack-ci-bot
Merge pull request #250 from charlieegan3/write-ssh-interface-fix
cdbcaef 
Automatic merge from submit-queue.

Update ssh config write to use latest interface

**What this PR does / why we need it**:
Fixes a bug introduced in #247

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note-none
NONE
```
@charlieegan3 charlieegan3 deleted the fix-ssh-config branch June 4, 2018 15:28
This was referenced Jul 25, 2018
Closed
Merged
jetstack-bot added a commit that referenced this pull request Jul 27, 2018
@jetstack-bot
Merge pull request #381 from dippynark/automated-cherry-pick-of-#247-#…
7785524 
…101-#287-#288-#293-#285-#299-#301-#304-#267-#305-#306-#326-#323-#322-#327-#330-#329-#346-#338-#313-#300-#296-#347-#295-#344-#235-#361-#365-#345-#343-#325-#336-#321-#371-#364-#378-origin-release-0.4

Automated cherry pick of #247 #101 #287 #288 #293 #285 #299 #301 #304 #267 #305 #306 #326 #323 #322 #327 #330 #329 #346 #338 #313 #300 #296 #347 #295 #344 #235 #361 #365 #345 #343 #325 #336 #321 #371 #364 #378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@simonswine simonswine

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@charlieegan3 @simonswine @jetstack-bot @jetstack-ci-bot @JoshVanL