Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Conversation

@dippynark
Copy link
Contributor

@dippynark dippynark commented Jun 21, 2018

What this PR does / why we need it: The worker pool is deployed with an unnecessary ELB

Fixes: #334

NONE

@jetstack-bot jetstack-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 21, 2018
@jetstack-bot jetstack-bot requested a review from kragniz June 21, 2018 18:34
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2018
@dippynark dippynark force-pushed the remove-internal-worker-elb branch from 8e7ec3a to a2cb15a Compare June 21, 2018 18:40
@dippynark
Copy link
Contributor Author

/assign @MattiasGees

@MattiasGees
Copy link
Member

Everything works
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2018
@simonswine simonswine assigned simonswine and unassigned MattiasGees Jul 13, 2018
@simonswine
Copy link
Contributor

/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants