Revert "feat(perf): Beasties critical CSS — homepage-only (#335)"#336
Conversation
This reverts commit 56cdc72.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR removes the critical CSS inlining feature from the build pipeline. The ChangesCritical CSS Inlining Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
User reports the Beasties homepage critical-CSS inlining (#335) caused design regression that wasn't caught by
bin/dtest's 84-screenshot baseline. Reverting to restore known-good state immediately.What this reverts
package.json+bun.lockb: dropsbeastiesdevDependencybin/hugo-build: removes thebin/inline-criticalinvocation blockbin/inline-critical+bin/inline-critical.mjs: deletedWhat this does NOT undo
.github/workflows/_hugo.yml, so CI deploy was never running Beasties — only local production builds viabin/hugo-build. The deployed site on master may be unaffected.content/blog/vibe-coding-disposable-by-design/cover.pngthat came along with feat(perf): Beasties critical CSS — homepage-only #335 stays — separate concern.Investigation followup (separate work)
The visual regression bin/dtest didn't catch the broken design. Two possible explanations to investigate:
Either way: the test gate wasn't broad enough. Future similar work should expand bin/dtest coverage to include the affected page/viewport BEFORE the implementation sprint, not after.
🤖 Generated with Claude Code
Summary by CodeRabbit