Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 26 26
Lines 1654 1654
Branches 374 374
=======================================
Hits 1379 1379
Misses 163 163
Partials 112 112 Continue to review full report at Codecov.
|
Contributor
Author
|
CC: @jettify |
Owner
|
Thanks! |
hedonemaeda
pushed a commit
to hedonemaeda/pytorch-optimizer
that referenced
this pull request
Mar 15, 2026
* patch-1 * lint * lint * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #368. I additionally fixed another 10 configurations which were causing the test to be flaky. I individually experimented with configs for each optimizer and found optimal values for which the test failure rate is ~0%.
Please let me know if this seems ok.
Also since the test is more stable now, do you think that the seed on Line 88 can be removed?