Improve EagerContentHandler
#13018
Merged
Improve EagerContentHandler
#13018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
gregw
approved these changes
Apr 22, 2025
Contributor
gregw
left a comment
gregw
left a comment
There was a problem hiding this comment.
This is good. Since this handler is really the replacement for delay dispatch until first content chunk, the not-reject behaviour is the correct default!
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Jetty 12.1.0 - (FROZEN)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default to not reject requests, as the
EagerContentHandlerjavadoc does not speak about this (only theRetainedContentLoaderFactoryconstructor does) and I find it to be an overly restrictive and surprising (as in: breaks your code in non-obvious way) default value.I've also slightly improved the
RetainedContentLoaderFactoryjavadoc.Fixes #13002