Introduce json schema validation #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the complexity of omniparser schemas (all of which are written in json), we'll use json schema to validate these schemas :) Created `schemavalidate` package for generating each schema section json schema and helper for doing json validation. Added `parser_settings` validation to parser.go Added `transform_declarations` validation to omniv2/plugin.go
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1037 1040 +3
=========================================
+ Hits 1037 1040 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the complexity of omniparser schemas (all of which are written in json), we'll use json schema to validate these schemas :)
Created
schemavalidatepackage for generating each schema section json schema and helper for doing json validation.Added
parser_settingsvalidation to parser.goAdded
transform_declarationsvalidation to omniv2/plugin.go