Made count_true a new format callable #2075
Conversation
SadiinsoSnowfall
changed the title
SadiinsoSnowfall
force-pushed
the
callable/count_true
branch
from
17a3ded to
4b9f64b
Compare
DenisYaroshevskiy
left a comment
DenisYaroshevskiy
left a comment
There was a problem hiding this comment.
Is this still in progress?
DenisYaroshevskiy
left a comment
DenisYaroshevskiy
left a comment
There was a problem hiding this comment.
Now that I undestand your changes to the test a bit more, here is what i suggest.
a) We stop calling count directly in test, we start calling test_count with logical and ignore
b) inside test_count function you add extra cases for all falses and maybe ignore.mask(as{})
|
Waiting for the text |
SadiinsoSnowfall
force-pushed
the
callable/count_true
branch
from
381414b to
b6158be
Compare
SadiinsoSnowfall
force-pushed
the
callable/count_true
branch
from
49af4e0 to
de115d1
Compare
| #endif | ||
|
|
||
| // Assume an expression to be true at compile time | ||
| #if defined(EVE_NO_ASSUME) |
There was a problem hiding this comment.
I don't think this goes in ABI but w/e. @jfalcou
test/unit/module/core/count_true.cpp
Outdated
| for (std::ptrdiff_t i = 0; i < cardinal / 4; ++i) | ||
| { | ||
| test_count_true(v, eve::keep_between(i, i + cardinal / 4)); | ||
| test_count_true(v, eve::ignore_extrema(i, i + cardinal / 4)); |
There was a problem hiding this comment.
where are the tests ignore everything?
There was a problem hiding this comment.
Just above, L98 and L87.
| } | ||
|
|
||
| template<typename T> | ||
| void test_count_true(T v) |
There was a problem hiding this comment.
If you say you now support not relative masks - I don't see tests.
No description provided.