docs(README.md): remove useless dependency #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As peerDependencies are automatically downloaded, this is not required to be part of the `npm i` scripts. It is also preferable to let it out, as : if a user would like to remove `ngx-markdown` the `marked` library will be removed automatically, but not if installed manually. It will also make library upload easier to manage, as the marked will be updated automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As peerDependencies are automatically downloaded, this is not required to be part of the
npm iscripts.It is also preferable to let it out, as :
if a user would like to remove
ngx-markdownthemarkedlibrary will be removed automatically, but not if installed manually.It will also make library upload easier to manage, as the marked will be updated automatically